tools: tplgtool2: Support for feature topologies and merging of topologies#1362
Open
ujfalusi wants to merge 3 commits into
Open
tools: tplgtool2: Support for feature topologies and merging of topologies#1362ujfalusi wants to merge 3 commits into
ujfalusi wants to merge 3 commits into
Conversation
Feature topologies may contain graph endpoints that do not map to a DAPM widget (for example, mixout.21.1). Make tplgtool2 robust to these graph-only nodes instead of raising KeyError while building graph metadata. Keep the issue visible by emitting a warning and by rendering graph-only nodes with a distinct style and label in graph output. This keeps parsing and rendering usable for feature topologies while still surfacing broken/incomplete graph<->widget mappings. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Add --merge to combine multiple tplg inputs into one view for pcm and graph dumping. Emit warnings for duplicate widget names, PCM IDs, and PCM names in merged mode. Document merge usage in tools/README.md and README.md. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Add unit tests for merged topology duplicate warning detection, including no-duplicate and duplicate cases. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
a team,
golowanow,
lgirdwood and
marc-hb
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #1361 (which will be closed):
It adds support for handling of feature topologies: fragment topologies which plugs into existing function or monolithic topology.
It also adds a new command line parameter:
--mergewhich will attempt to merge the topology files specified as command line parameters into a single view with noting the source of widgets and merge point(s):